Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move forward cache and computed to device #413

Merged
merged 9 commits into from
Aug 2, 2021

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jul 29, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #392
Also moved the computed and forward cache to right device

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Jul 29, 2021
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #413 (249266c) into master (d5aa720) will increase coverage by 19.69%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #413       +/-   ##
===========================================
+ Coverage   75.69%   95.38%   +19.69%     
===========================================
  Files         124      124               
  Lines        3982     3986        +4     
===========================================
+ Hits         3014     3802      +788     
+ Misses        968      184      -784     
Flag Coverage Δ
Linux 75.61% <0.00%> (-0.08%) ⬇️
Windows 75.61% <0.00%> (-0.08%) ⬇️
cpu 95.38% <50.00%> (+19.69%) ⬆️
macOS 95.38% <50.00%> (+19.69%) ⬆️
pytest 95.38% <50.00%> (+19.69%) ⬆️
python3.8 95.33% <50.00%> (?)
torch1.4.0 95.33% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/metric.py 92.14% <50.00%> (+34.95%) ⬆️
torchmetrics/functional/regression/spearman.py 93.33% <0.00%> (+2.22%) ⬆️
torchmetrics/regression/r2.py 94.28% <0.00%> (+2.85%) ⬆️
torchmetrics/regression/explained_variance.py 97.05% <0.00%> (+2.94%) ⬆️
torchmetrics/functional/regression/pearson.py 100.00% <0.00%> (+3.12%) ⬆️
torchmetrics/classification/average_precision.py 96.87% <0.00%> (+3.12%) ⬆️
...chmetrics/classification/precision_recall_curve.py 96.87% <0.00%> (+3.12%) ⬆️
torchmetrics/classification/roc.py 96.77% <0.00%> (+3.22%) ⬆️
torchmetrics/utilities/enums.py 100.00% <0.00%> (+3.44%) ⬆️
torchmetrics/regression/cosine_similarity.py 96.42% <0.00%> (+3.57%) ⬆️
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5aa720...249266c. Read the comment docs.

@mergify mergify bot removed the has conflicts label Jul 30, 2021
@mergify mergify bot removed the ready label Aug 2, 2021
@SkafteNicki SkafteNicki enabled auto-merge (squash) August 2, 2021 11:37
@SkafteNicki SkafteNicki merged commit 4fd18b3 into master Aug 2, 2021
@SkafteNicki SkafteNicki deleted the forward_and_compute_to_device branch August 2, 2021 13:37
@Borda Borda added this to the v0.5 milestone Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forward_cache / computed should be moved too on device.
3 participants